Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_feature_names to OneHotEncoder #4596

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Add get_feature_names to OneHotEncoder #4596

merged 2 commits into from
Mar 24, 2022

Conversation

viclafargue
Copy link
Contributor

Answers #4586

@viclafargue viclafargue requested a review from a team as a code owner February 22, 2022 15:11
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 22, 2022
@caryr35 caryr35 added this to PR-WIP in v22.04 Release via automation Feb 22, 2022
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v22.04 Release Feb 22, 2022
@viclafargue viclafargue added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 24, 2022
@dantegd
Copy link
Member

dantegd commented Feb 28, 2022

rerun tests

dantegd
dantegd approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending CI once it is unblocked

v22.04 Release automation moved this from PR-Needs review to PR-Reviewer approved Mar 10, 2022
@dantegd dantegd self-assigned this Mar 10, 2022
@viclafargue
Copy link
Contributor Author

rerun tests

2 similar comments
@viclafargue
Copy link
Contributor Author

rerun tests

@dantegd
Copy link
Member

dantegd commented Mar 24, 2022

rerun tests

@dantegd
Copy link
Member

dantegd commented Mar 24, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@647f7cd). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.04    #4596   +/-   ##
===============================================
  Coverage                ?   84.21%           
===============================================
  Files                   ?      251           
  Lines                   ?    20807           
  Branches                ?        0           
===============================================
  Hits                    ?    17522           
  Misses                  ?     3285           
  Partials                ?        0
Flag Coverage Δ
dask 45.26% <0.00%> (?)
non-dask 77.47% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647f7cd...b2d9174. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 4ca80a9 into rapidsai:branch-22.04 Mar 24, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Mar 24, 2022
@viclafargue viclafargue mentioned this pull request Mar 28, 2022
Closed
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@viclafargue
Add get_feature_names to OneHotEncoder (rapidsai#4596)
b56823b 
Answers rapidsai#4586

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees

@dantegd dantegd

Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v22.04 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viclafargue @dantegd @codecov-commenter