Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Fitsne as default tsne method #4597

Merged
merged 3 commits into from
Feb 25, 2022
Merged

[FEA] Fitsne as default tsne method #4597

merged 3 commits into from
Feb 25, 2022

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Feb 22, 2022

Closes #4566.

@lowener lowener requested a review from a team as a code owner February 22, 2022 18:55
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 22, 2022
@cjnolet cjnolet added this to PR-WIP in v22.04 Release via automation Feb 23, 2022
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 23, 2022
cjnolet
cjnolet approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should still create an issue to fix the early stopping for FFT, but otherwise LGTM and I think we should go ahead and merge this.

v22.04 Release automation moved this from PR-WIP to PR-Reviewer approved Feb 25, 2022
@cjnolet
Copy link
Member

cjnolet commented Feb 25, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 701b62f into rapidsai:branch-22.04 Feb 25, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Feb 25, 2022
@lowener lowener deleted the 22.04-tsne-fft branch February 25, 2022 22:59
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@lowener
Fitsne as default tsne method (rapidsai#4597)
2b85164 
Closes rapidsai#4566.

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v22.04 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] FIt-SNE be default for t-sne in cuML 22.04
2 participants
@lowener @cjnolet