Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuml now supports building non static treelite #4598

Merged
merged 1 commit into from
Feb 23, 2022
Merged

cuml now supports building non static treelite #4598

merged 1 commit into from
Feb 23, 2022

Conversation

robertmaynard
Copy link
Contributor

No description provided.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Feb 22, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner February 22, 2022 20:54
@robertmaynard robertmaynard added this to PR-WIP in v22.04 Release via automation Feb 22, 2022
@dantegd
Copy link
Member

dantegd commented Feb 23, 2022

rerun tests

v22.04 Release automation moved this from PR-WIP to PR-Reviewer approved Feb 23, 2022
@dantegd
Copy link
Member

dantegd commented Feb 23, 2022

rerun tests

1 similar comment
@robertmaynard
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@6cf64f6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4598   +/-   ##
===============================================
  Coverage                ?   83.88%           
===============================================
  Files                   ?      250           
  Lines                   ?    20061           
  Branches                ?        0           
===============================================
  Hits                    ?    16828           
  Misses                  ?     3233           
  Partials                ?        0
Flag Coverage Δ
dask 45.17% <0.00%> (?)
non-dask 76.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf64f6...1868ada. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Feb 23, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5a18429 into rapidsai:branch-22.04 Feb 23, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Feb 23, 2022
@robertmaynard robertmaynard deleted the support_static_and_shared_treelite branch August 1, 2022 13:47
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@robertmaynard
cuml now supports building non static treelite (rapidsai#4598)
02a8cd4 
Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CUDA/C++ non-breaking Non-breaking change
Projects
No open projects
v22.04 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robertmaynard @dantegd @codecov-commenter