Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix document layouts in Parameters sections #4609

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Fix document layouts in Parameters sections #4609

merged 1 commit into from
Mar 1, 2022

Conversation

Yosshi999
Copy link
Contributor

like the figure below in https://docs.rapids.ai/api/cuml/stable/api.html#cuml.neighbors.NearestNeighbors

image

Some captions are going into their heading.

@Yosshi999 Yosshi999 requested a review from a team as a code owner February 28, 2022 22:51
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 28, 2022
@cjnolet
Copy link
Member

cjnolet commented Feb 28, 2022

Ok to test

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change doc Documentation and removed improvement Improvement / enhancement to an existing function labels Feb 28, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@a2c91a6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4609   +/-   ##
===============================================
  Coverage                ?   83.89%           
===============================================
  Files                   ?      250           
  Lines                   ?    20083           
  Branches                ?        0           
===============================================
  Hits                    ?    16848           
  Misses                  ?     3235           
  Partials                ?        0
Flag Coverage Δ
dask 45.11% <0.00%> (?)
non-dask 76.99% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c91a6...a1c85fc. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Mar 1, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b0cccb5 into rapidsai:branch-22.04 Mar 1, 2022
@Yosshi999 Yosshi999 deleted the fix-docs-layout branch March 2, 2022 03:22
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@Yosshi999
Fix document layouts in Parameters sections (rapidsai#4609)
8bcf62e 
like the figure below in https://docs.rapids.ai/api/cuml/stable/api.html#cuml.neighbors.NearestNeighbors
 
![image](https://user-images.githubusercontent.com/8027142/156071101-0a5bf96a-e073-4dea-8314-dfec733699c2.png)

Some captions are going into their heading.

Authors:
  - https://github.com/Yosshi999

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
Cython / Python Cython or Python issue doc Documentation non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Yosshi999 @GPUtester @cjnolet @codecov-commenter @dantegd