Templatizing FIL types to add float64 support #4625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantegd
added
improvement
|
@divyegala I've responded to your comments and updated one of the documentation comments to make it clearer. Could you take another look? |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #4625 +/- ##
===============================================
Coverage ? 83.85%
===============================================
Files ? 251
Lines ? 20282
Branches ? 0
===============================================
Hits ? 17007
Misses ? 3275
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
dantegd
added
the
4 - Waiting on Reviewer
divyegala
approved these changes
Mar 14, 2022
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Templatize FIL types to add float64 support. This is based on the work by @levsnv, specifically rapidsai#4569. This supersedes rapidsai#4569. Authors: - Andy Adinets (https://github.com/canonizer) - Levs Dolgovs (https://github.com/levsnv) Approvers: - Divye Gala (https://github.com/divyegala) URL: rapidsai#4625
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templatize FIL types to add float64 support.
This is based on the work by @levsnv, specifically #4569. This supersedes #4569.