Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Small fixes for certain test failures #4628

Merged
merged 1 commit into from
Mar 10, 2022
Merged

[REVIEW] Small fixes for certain test failures #4628

merged 1 commit into from
Mar 10, 2022

Conversation

vinaydes
Copy link
Contributor

RAFT PR 513 changed meaning of probability for Bernoulli and Scaled Bernoulli distribution. This PR does corresponding change in cuML.

@vinaydes vinaydes requested a review from a team as a code owner March 10, 2022 18:31
@cjnolet cjnolet added this to PR-WIP in v22.04 Release via automation Mar 10, 2022
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 10, 2022
@vinaydes vinaydes mentioned this pull request Mar 10, 2022
Closed
v22.04 Release automation moved this from PR-WIP to PR-Reviewer approved Mar 10, 2022
cjnolet
cjnolet approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Mar 10, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@4c1d671). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4628   +/-   ##
===============================================
  Coverage                ?   83.85%           
===============================================
  Files                   ?      251           
  Lines                   ?    20282           
  Branches                ?        0           
===============================================
  Hits                    ?    17008           
  Misses                  ?     3274           
  Partials                ?        0
Flag Coverage Δ
dask 44.93% <0.00%> (?)
non-dask 77.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c1d671...76c513d. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Mar 10, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c2594f1 into rapidsai:branch-22.04 Mar 10, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Mar 10, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@vinaydes
Small fixes for certain test failures (rapidsai#4628)
0306eec 
RAFT PR 513 changed meaning of probability for Bernoulli and Scaled Bernoulli distribution. This PR does corresponding change in cuML.

Authors:
  - Vinay Deshpande (https://github.com/vinaydes)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v22.04 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vinaydes @cjnolet @codecov-commenter @dantegd