Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding some prints when hdbscan assertion fails #4656

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Adding some prints when hdbscan assertion fails #4656

merged 2 commits into from
Mar 24, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Mar 23, 2022

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 23, 2022
@cjnolet cjnolet requested a review from a team as a code owner March 23, 2022 22:46
@cjnolet cjnolet added this to PR-WIP in v22.04 Release via automation Mar 23, 2022
v22.04 Release automation moved this from PR-WIP to PR-Reviewer approved Mar 23, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Mar 24, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@3f54aec). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.04    #4656   +/-   ##
===============================================
  Coverage                ?   83.86%           
===============================================
  Files                   ?      251           
  Lines                   ?    20293           
  Branches                ?        0           
===============================================
  Hits                    ?    17018           
  Misses                  ?     3275           
  Partials                ?        0
Flag Coverage Δ
dask 44.92% <0.00%> (?)
non-dask 77.02% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f54aec...d3e7f9f. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 2bd7737 into rapidsai:branch-22.04 Mar 24, 2022
v22.04 Release automation moved this from PR-Reviewer approved to Done Mar 24, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
Adding some prints when hdbscan assertion fails (rapidsai#4656)
10ac23a 
Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v22.04 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cjnolet @codecov-commenter @dantegd