Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Refactor tests in cuml #4703

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

galipremsagar
Copy link
Contributor

This PR:

  • Moves all pytest from test to tests
  • Converts test module to tests directory
  • Creates a testing module that contains all utility functions for pytests in tests need.

@galipremsagar galipremsagar requested review from a team as code owners April 21, 2022 17:25
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added Cython / Python Cython or Python issue gpuCI gpuCI issue labels Apr 21, 2022
@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 21, 2022
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@galipremsagar
Copy link
Contributor Author

rerun tests

@caryr35 caryr35 added this to PR-WIP in v22.06 Release via automation Apr 21, 2022
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v22.06 Release Apr 21, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.06@b3967cf). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.06    #4703   +/-   ##
===============================================
  Coverage                ?   89.00%           
===============================================
  Files                   ?      369           
  Lines                   ?    34567           
  Branches                ?        0           
===============================================
  Hits                    ?    30766           
  Misses                  ?     3801           
  Partials                ?        0           
Flag Coverage Δ
dask 34.33% <0.00%> (?)
non-dask 84.33% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3967cf...5c78e49. Read the comment docs.

v22.06 Release automation moved this from PR-Needs review to PR-Reviewer approved Apr 22, 2022
@dantegd
Copy link
Member

dantegd commented Apr 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6145ef3 into rapidsai:branch-22.06 Apr 22, 2022
v22.06 Release automation moved this from PR-Reviewer approved to Done Apr 22, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
This PR:

- [x] Moves all pytest from `test` to `tests`
- [x] Converts `test` module to `tests` directory
- [x] Creates a `testing` module that contains all utility functions for pytests in `tests` need.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Jordan Jacobelli (https://github.com/Ethyling)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cython / Python Cython or Python issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants