Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use KMeans from Raft #4713

Merged
merged 53 commits into from
Nov 8, 2022
Merged

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Apr 26, 2022

No description provided.

@github-actions github-actions bot added CMake CUDA/C++ Cython / Python Cython or Python issue labels Apr 26, 2022
@caryr35 caryr35 removed this from PR-Needs review in v22.10 Release Oct 18, 2022
@caryr35 caryr35 added this to PR-WIP in v22.12 Release via automation Oct 18, 2022
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v22.12 Release Oct 18, 2022
@cjnolet
Copy link
Member

cjnolet commented Oct 20, 2022

rerun tests

@github-actions github-actions bot added the CMake label Oct 31, 2022
@lowener
Copy link
Contributor Author

lowener commented Nov 1, 2022

rerun tests

rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Nov 8, 2022
This is also fixing a bug in kmeans `shuffle_and_gather` function and is needed by rapidsai/cuml#4713

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #982
@lowener
Copy link
Contributor Author

lowener commented Nov 8, 2022

rerun tests

v22.12 Release automation moved this from PR-Needs review to PR-Reviewer approved Nov 8, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@8aae5aa). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.12    #4713   +/-   ##
===============================================
  Coverage                ?   79.49%           
===============================================
  Files                   ?      183           
  Lines                   ?    11617           
  Branches                ?        0           
===============================================
  Hits                    ?     9235           
  Misses                  ?     2382           
  Partials                ?        0           
Flag Coverage Δ
dask 46.13% <0.00%> (?)
non-dask 68.95% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cjnolet
Copy link
Member

cjnolet commented Nov 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b4967bf into rapidsai:branch-22.12 Nov 8, 2022
v22.12 Release automation moved this from PR-Reviewer approved to Done Nov 8, 2022
v22.12 Release automation moved this from Done to PR-Reviewer approved Nov 8, 2022
@lowener lowener deleted the 22.06-kmeans-raft branch November 8, 2022 23:37
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v22.12 Release
  
PR-Reviewer approved
Development

Successfully merging this pull request may close these issues.

None yet

4 participants