Use raft::span in TreeExplainer #4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…treeshap-refactor
…treeshap-refactor
…treeshap-refactor
hcho3
added
non-breaking
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #4714 +/- ##
===============================================
Coverage ? 79.89%
===============================================
Files ? 180
Lines ? 11371
Branches ? 0
===============================================
Hits ? 9085
Misses ? 2286
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@RAMitchell @trivialfis Can I get a review? |
RAMitchell
reviewed
May 11, 2022
| @@ -200,14 +171,30 @@ struct SplitCondition { | |||
| // Combine two split conditions on the same feature | |||
| __host__ __device__ void Merge(const SplitCondition& other) | |||
There was a problem hiding this comment.
Does merge ever get called on the host? Just wondering if we can remove the host categories.
trivialfis
approved these changes
May 11, 2022
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Now that RAFT has a `span` implementation, use that in TreeExplainer. Authors: - Philip Hyunsu Cho (https://github.com/hcho3) - Rory Mitchell (https://github.com/RAMitchell) Approvers: - Jiaming Yuan (https://github.com/trivialfis) - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that RAFT has a
spanimplementation, use that in TreeExplainer.