Fix docs builds #4733
Merged
Fix docs builds #4733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevagh
approved these changes
May 13, 2022
|
admin merging since this isn't tested in CI |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
This PR fixes our nightly docs build by removing the `exit` statement at the bottom of this script. In our nightly docs builds, this script is invoked via `source`, so any `exit` statements cause the parent script to exit which prevents completion of the rest of the build. It also removes some unnecessary `pip`/`conda` install commands since these packages exist already in the container. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Sevag Hanssian (https://github.com/sevagh)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes our nightly docs build by removing the
exitstatement at the bottom of this script. In our nightly docs builds, this script is invoked viasource, so anyexitstatements cause the parent script to exit which prevents completion of the rest of the build.It also removes some unnecessary
pip/condainstall commands since these packages exist already in the container.