Resolve KRR hypothesis test failure #4761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
approved these changes
May 27, 2022
|
rerun tests |
|
Can always expect the most random test failures right as we are going into a release. |
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #4761 +/- ##
===============================================
Coverage ? 79.93%
===============================================
Files ? 180
Lines ? 11379
Branches ? 0
===============================================
Hits ? 9096
Misses ? 2283
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
On updating the hypothesis version, examples were generated with very small values. Both sklearn and cuml experience numerical instability for the cosine kernel in these cases. I have verified that after this PR, the test passes with up to 10000 examples. Authors: - Rory Mitchell (https://github.com/RAMitchell) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On updating the hypothesis version, examples were generated with very small values. Both sklearn and cuml experience numerical instability for the cosine kernel in these cases.
I have verified that after this PR, the test passes with up to 10000 examples.