Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sg benchmark build. #4766

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Fix sg benchmark build. #4766

merged 1 commit into from
Jun 2, 2022

Conversation

trivialfis
Copy link
Member

Fix static storage error:

/usr/bin/ld: bench/CMakeFiles/sg_benchmark.dir/sg/arima_loglikelihood.cu.o: in function `ML::Bench::Fixture::SetUp(benchmark::State const&)':
tmpxft_0000bc8b_00000000-6_arima_loglikelihood.cudafe1.cpp:(.text._ZN2ML5Bench7Fixture5SetUpERKN9benchmark5StateE[_ZN2ML5Bench7Fixture5SetUpERKN9benchmark5StateE]+0x2d): undefined reference to `ML::Bench::Fixture::NumStreams'

@trivialfis trivialfis added bug Something isn't working non-breaking Non-breaking change labels Jun 2, 2022
@trivialfis trivialfis requested a review from a team as a code owner June 2, 2022 11:10
viclafargue
viclafargue approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, LGTM

@dantegd
Copy link
Member

dantegd commented Jun 2, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9cdd8d0 into rapidsai:branch-22.06 Jun 2, 2022
@trivialfis trivialfis deleted the fix-sg-bench-build branch June 2, 2022 15:17
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@trivialfis
Fix sg benchmark build. (rapidsai#4766)
1fbe86e 
Fix static storage error:

```
/usr/bin/ld: bench/CMakeFiles/sg_benchmark.dir/sg/arima_loglikelihood.cu.o: in function `ML::Bench::Fixture::SetUp(benchmark::State const&)':
tmpxft_0000bc8b_00000000-6_arima_loglikelihood.cudafe1.cpp:(.text._ZN2ML5Bench7Fixture5SetUpERKN9benchmark5StateE[_ZN2ML5Bench7Fixture5SetUpERKN9benchmark5StateE]+0x2d): undefined reference to `ML::Bench::Fixture::NumStreams'
```

Authors:
  - Jiaming Yuan (https://github.com/trivialfis)

Approvers:
  - Victor Lafargue (https://github.com/viclafargue)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@viclafargue viclafargue viclafargue approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CUDA/C++ non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trivialfis @dantegd @viclafargue