Fix #3414: remove naive versions dbscan algorithms #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahendriksen
added
improvement
|
This PR is follow up to #4803. |
ahendriksen
force-pushed
the
fix-3414-remove-naive-versions-dbscan-algorithms
branch
from
7dab7e2
to
badcb20
Compare
ahendriksen
force-pushed
the
fix-3414-remove-naive-versions-dbscan-algorithms
branch
from
badcb20
to
823474f
Compare
ahendriksen
added
3 - Ready for Review
This functionality has been moved to RAFT.
This fixes issue rapidsai#3414.
ahendriksen
force-pushed
the
fix-3414-remove-naive-versions-dbscan-algorithms
branch
from
823474f
to
41405d5
Compare
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #4804 +/- ##
=============================================
Coverage 77.62% 77.62%
=============================================
Files 180 180
Lines 11384 11384
=============================================
Hits 8837 8837
Misses 2547 2547
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
cjnolet
reviewed
Jul 25, 2022
ahendriksen
added
5 - Ready to Merge
cjnolet
approved these changes
Jul 26, 2022
|
@gpucibot merge |
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
…4804) This PR removes the naive versions of the DBSCAN algorithms. They were not used anymore and were largely incorrect, as described in rapidsai#3414. This fixes issue rapidsai#3414. Authors: - Allard Hendriksen (https://github.com/ahendriksen) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the naive versions of the DBSCAN algorithms. They were not used anymore and were largely incorrect, as described in #3414.
This fixes issue #3414.