Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conda environment files to UCX 1.13.0 #4813

Merged

Conversation

pentschev
Copy link
Member

@pentschev pentschev commented Jul 13, 2022

The conda recipe was updated to UCX 1.13.0 in #4809 , but updating conda environment files was missing there.

@pentschev pentschev requested a review from a team as a code owner July 13, 2022 06:11
@github-actions github-actions bot added the conda conda issue label Jul 13, 2022
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 13, 2022
@cjnolet cjnolet added this to PR-WIP in v22.08 Release via automation Jul 13, 2022
v22.08 Release automation moved this from PR-WIP to PR-Reviewer approved Jul 13, 2022
@dantegd
Copy link
Member

dantegd commented Jul 18, 2022

rerun tests

1 similar comment
@cjnolet
Copy link
Member

cjnolet commented Jul 25, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

Merging #4813 (944c896) into branch-22.08 (b5a48db) will increase coverage by 0.00%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           branch-22.08    #4813   +/-   ##
=============================================
  Coverage         77.62%   77.62%           
=============================================
  Files               180      180           
  Lines             11382    11384    +2     
=============================================
+ Hits               8835     8837    +2     
  Misses             2547     2547           
Flag Coverage Δ
dask 45.52% <ø> (+<0.01%) ⬆️
non-dask 67.26% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/metrics/__init__.py 100.00% <0.00%> (ø)
python/cuml/metrics/cluster/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5a48db...944c896. Read the comment docs.

@cjnolet
Copy link
Member

cjnolet commented Jul 27, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5324d52 into rapidsai:branch-22.08 Jul 27, 2022
v22.08 Release automation moved this from PR-Reviewer approved to Done Jul 27, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
The conda recipe was updated to UCX 1.13.0 in rapidsai#4809 , but updating conda environment files was missing there.

Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Jordan Jacobelli (https://github.com/Ethyling)

URL: rapidsai#4813
@pentschev pentschev deleted the ucx-1.13-update-conda-files branch May 20, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants