Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the NVTX bench helper for the new nsys utility #4826

Merged
merged 3 commits into from Sep 1, 2022

Conversation

viclafargue
Copy link
Contributor

No description provided.

@viclafargue viclafargue requested a review from a team as a code owner July 21, 2022 14:18
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jul 21, 2022
@caryr35 caryr35 added this to PR-WIP in v22.08 Release via automation Jul 25, 2022
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v22.08 Release Jul 25, 2022
@caryr35 caryr35 added this to PR-WIP in v22.10 Release via automation Aug 4, 2022
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v22.10 Release Aug 4, 2022
@caryr35 caryr35 removed this from PR-Needs review in v22.08 Release Aug 4, 2022
@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@dantegd dantegd changed the base branch from branch-22.08 to branch-22.10 August 31, 2022 17:59
@dantegd dantegd added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 31, 2022
v22.10 Release automation moved this from PR-Needs review to PR-Reviewer approved Aug 31, 2022
@dantegd
Copy link
Member

dantegd commented Aug 31, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

Base: 78.02% // Head: 78.04% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (dc996d2) compared to base (7a0ab85).
Patch coverage: 84.90% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.10    #4826      +/-   ##
================================================
+ Coverage         78.02%   78.04%   +0.02%     
================================================
  Files               180      180              
  Lines             11385    11423      +38     
================================================
+ Hits               8883     8915      +32     
- Misses             2502     2508       +6     
Flag Coverage Δ
dask 46.29% <67.92%> (+0.07%) ⬆️
non-dask 67.32% <84.90%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/benchmark/nvtx_benchmark.py 0.00% <0.00%> (ø)
python/cuml/common/array.py 95.10% <85.10%> (-2.88%) ⬇️
python/cuml/cluster/__init__.py 100.00% <100.00%> (ø)
python/cuml/metrics/__init__.py 100.00% <100.00%> (ø)
python/cuml/thirdparty_adapters/adapters.py 91.54% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rapids-bot rapids-bot bot merged commit 9320e47 into rapidsai:branch-22.10 Sep 1, 2022
v22.10 Release automation moved this from PR-Reviewer approved to Done Sep 1, 2022
rapids-bot bot pushed a commit that referenced this pull request Sep 8, 2022
- Fix for MNMG TSVD (similar issue to [cudaErrorContextIsDestroyed in RandomForest](#2632 (comment)))
- #4826
- MNMG Kmeans testing issue : modification of accuracy threshold
- MNMG KNNRegressor testing issue : modification of input for testing
- LabelEncoder documentation test issue : modification of pandas/cuDF display configuration
- RandomForest testing issue : adjust number of estimators to the number of workers

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4840
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
- Fix for MNMG TSVD (similar issue to [cudaErrorContextIsDestroyed in RandomForest](rapidsai#2632 (comment)))
- rapidsai#4826
- MNMG Kmeans testing issue : modification of accuracy threshold
- MNMG KNNRegressor testing issue : modification of input for testing
- LabelEncoder documentation test issue : modification of pandas/cuDF display configuration
- RandomForest testing issue : adjust number of estimators to the number of workers

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants