Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Centralize common css & js code in docs #4844

Merged
merged 8 commits into from
Aug 4, 2022

Conversation

galipremsagar
Copy link
Contributor

This PR will utilize the common css & js code being merged here: rapidsai/docs#286

@galipremsagar galipremsagar requested a review from a team as a code owner July 29, 2022 21:21
@galipremsagar galipremsagar added doc Documentation non-breaking Non-breaking change labels Aug 1, 2022
@cjnolet
Copy link
Member

cjnolet commented Aug 2, 2022

@galipremsagar is this also going to be needed for the RAFT docs?

@galipremsagar
Copy link
Contributor Author

@galipremsagar is this also going to be needed for the RAFT docs?

Hmm, yes it does. Opening a PR now. I opened a PR to all repos listed here: https://docs.rapids.ai/api and since I couldn't find any raft doxygen docs I was under an assumption that it was not being used. But looking into the repo I see we need a similar change there too.

@galipremsagar
Copy link
Contributor Author

@cjnolet Here is the PR: rapidsai/raft#773

@dantegd
Copy link
Member

dantegd commented Aug 2, 2022

@gpucibot merge

@galipremsagar galipremsagar requested a review from a team as a code owner August 3, 2022 14:24
@github-actions github-actions bot added the conda conda issue label Aug 3, 2022
@dantegd
Copy link
Member

dantegd commented Aug 3, 2022

rerun tests

@caryr35 caryr35 added this to PR-WIP in v22.08 Release via automation Aug 3, 2022
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v22.08 Release Aug 3, 2022
@dantegd
Copy link
Member

dantegd commented Aug 3, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

Merging #4844 (2146bb8) into branch-22.08 (350d709) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           branch-22.08    #4844   +/-   ##
=============================================
  Coverage         78.02%   78.02%           
=============================================
  Files               180      180           
  Lines             11385    11385           
=============================================
  Hits               8883     8883           
  Misses             2502     2502           
Flag Coverage Δ
dask 46.21% <ø> (ø)
non-dask 67.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rapids-bot rapids-bot bot merged commit 55d3ef4 into rapidsai:branch-22.08 Aug 4, 2022
v22.08 Release automation moved this from PR-Needs review to Done Aug 4, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
This PR will utilize the common css & js code being merged here: rapidsai/docs#286

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue CUDA/C++ doc Documentation non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants