Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Use common code in python docs and defer js loading #4852

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

galipremsagar
Copy link
Contributor

This PR makes a switch to utilizing common js & css code and defer's loading of custom js.

@galipremsagar galipremsagar added doc Documentation non-breaking Non-breaking change labels Aug 4, 2022
@ajschmidt8
Copy link
Member

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

Merging #4852 (70bae95) into branch-22.08 (55d3ef4) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           branch-22.08    #4852   +/-   ##
=============================================
  Coverage         78.02%   78.02%           
=============================================
  Files               180      180           
  Lines             11385    11385           
=============================================
  Hits               8883     8883           
  Misses             2502     2502           
Flag Coverage Δ
dask 46.21% <ø> (ø)
non-dask 67.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rapids-bot rapids-bot bot merged commit 63e8807 into rapidsai:branch-22.08 Aug 4, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
This PR makes a switch to utilizing common `js` & `css` code and defer's loading of custom js.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#4852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants