Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rapids-cmake 22.10 best practice for RAPIDS.cmake location #4862

Conversation

robertmaynard
Copy link
Contributor

Removes possibility of another projects RAPIDS.cmake being used, and removes need to always download a version.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change CMake labels Aug 8, 2022
@robertmaynard robertmaynard added this to PR-WIP in v22.10 Release via automation Aug 8, 2022
@github-actions github-actions bot removed the CMake label Aug 8, 2022
@robertmaynard robertmaynard force-pushed the place_rapids.cmake_in_current_bin_dir branch from 1d1ca70 to 2a0096b Compare August 11, 2022 12:57
@galipremsagar
Copy link
Contributor

rerun tests

Removes possibility of another projects RAPIDS.cmake being used,
and removes need to always download a version.
@robertmaynard robertmaynard force-pushed the place_rapids.cmake_in_current_bin_dir branch from 2a0096b to 3f745db Compare August 19, 2022 13:27
v22.10 Release automation moved this from PR-WIP to PR-Reviewer approved Aug 25, 2022
@dantegd
Copy link
Member

dantegd commented Aug 25, 2022

rerun tests

@dantegd
Copy link
Member

dantegd commented Aug 25, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8ded83a into rapidsai:branch-22.10 Aug 25, 2022
v22.10 Release automation moved this from PR-Reviewer approved to Done Aug 25, 2022
@robertmaynard robertmaynard deleted the place_rapids.cmake_in_current_bin_dir branch August 26, 2022 12:52
divyegala pushed a commit to viclafargue/cuml that referenced this pull request Sep 2, 2022
…sai#4862)

Removes possibility of another projects RAPIDS.cmake being used, and removes need to always download a version.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4862
ajschmidt8 pushed a commit that referenced this pull request Feb 13, 2023
Removes possibility of another projects RAPIDS.cmake being used, and removes need to always download a version.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4862
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
…sai#4862)

Removes possibility of another projects RAPIDS.cmake being used, and removes need to always download a version.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants