Update for thrust 1.17 and fixes to accommodate for cuDF Buffer refactor #4871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantegd
added
bug
dantegd
changed the title
wphicks
approved these changes
Aug 23, 2022
cjnolet
approved these changes
Aug 23, 2022
|
rerun tests |
viclafargue
approved these changes
Aug 24, 2022
|
rerun tests |
1 similar comment
|
rerun tests |
python/cuml/common/array.py
Outdated
Comment on lines
331
to
340
| def host_serialize(self): | ||
| """Serialize data and metadata associated with host memory. | ||
| Returns | ||
| ------- | ||
| header : dict | ||
| The metadata required to reconstruct the object. | ||
| frames : list | ||
| The Buffers or memoryviews that the object should contain. | ||
| :meta private: | ||
| """ |
There was a problem hiding this comment.
Suggested change
| def host_serialize(self): | |
| """Serialize data and metadata associated with host memory. | |
| Returns | |
| ------- | |
| header : dict | |
| The metadata required to reconstruct the object. | |
| frames : list | |
| The Buffers or memoryviews that the object should contain. | |
| :meta private: | |
| """ | |
| def host_serialize(self): | |
| """ | |
| Serialize data and metadata associated with host memory. | |
| Returns | |
| ------- | |
| header : dict | |
| The metadata required to reconstruct the object. | |
| frames : list | |
| The Buffers or memoryviews that the object should contain. | |
| :meta private: | |
| """ |
There was a problem hiding this comment.
This is to fix the current error in CI:
Warning, treated as error:
/workspace/python/cuml/common/array.py:docstring of cuml.common.array.CumlArray.host_serialize:6:Unexpected indentation.
make: *** [Makefile:20: html] Error 2
|
rerun tests |
vinaydes
reviewed
Aug 25, 2022
| @@ -221,7 +221,7 @@ __global__ void excess_sample_with_replacement_kernel( | |||
| // compute the adjacent differences according to the functor | |||
| // TODO: Replace deprecated 'FlagHeads' with 'SubtractLeft' when it is available | |||
There was a problem hiding this comment.
Suggested change
| // TODO: Replace deprecated 'FlagHeads' with 'SubtractLeft' when it is available |
We can remove this comment now.
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #4871 +/- ##
================================================
+ Coverage 78.02% 78.04% +0.01%
================================================
Files 180 180
Lines 11385 11421 +36
================================================
+ Hits 8883 8913 +30
- Misses 2502 2508 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@gpucibot merge |
divyegala
pushed a commit
to viclafargue/cuml
that referenced
this pull request
Sep 2, 2022
…tor (rapidsai#4871) Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - William Hicks (https://github.com/wphicks) - Corey J. Nolet (https://github.com/cjnolet) - Victor Lafargue (https://github.com/viclafargue) URL: rapidsai#4871
ajschmidt8
pushed a commit
that referenced
this pull request
Feb 13, 2023
…tor (#4871) Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - William Hicks (https://github.com/wphicks) - Corey J. Nolet (https://github.com/cjnolet) - Victor Lafargue (https://github.com/viclafargue) URL: #4871
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
…tor (rapidsai#4871) Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - William Hicks (https://github.com/wphicks) - Corey J. Nolet (https://github.com/cjnolet) - Victor Lafargue (https://github.com/viclafargue) URL: rapidsai#4871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.