Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused cuDF imports #4873

Conversation

beckernick
Copy link
Member

For housekeeping, this PR removes unused cuDF imports across a variety of files.

It does not refactor any code that currently relies on cuDF.

@beckernick beckernick added bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change labels Aug 22, 2022
@beckernick beckernick requested a review from a team as a code owner August 22, 2022 22:49
@dantegd
Copy link
Member

dantegd commented Aug 26, 2022

rerun tests

@dantegd
Copy link
Member

dantegd commented Aug 26, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

Merging #4873 (cedec13) into branch-22.10 (7a0ab85) will increase coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.10    #4873      +/-   ##
================================================
+ Coverage         78.02%   78.04%   +0.01%     
================================================
  Files               180      180              
  Lines             11385    11421      +36     
================================================
+ Hits               8883     8913      +30     
- Misses             2502     2508       +6     
Flag Coverage Δ
dask 46.28% <ø> (+0.06%) ⬆️
non-dask 67.32% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/common/array.py 95.10% <0.00%> (-2.88%) ⬇️
python/cuml/thirdparty_adapters/adapters.py 91.54% <0.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rapids-bot rapids-bot bot merged commit 319d12c into rapidsai:branch-22.10 Aug 26, 2022
divyegala pushed a commit to viclafargue/cuml that referenced this pull request Sep 2, 2022
For housekeeping, this PR removes unused cuDF imports across a variety of files.

It does not refactor any code that currently relies on cuDF.

Authors:
  - Nick Becker (https://github.com/beckernick)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4873
@beckernick beckernick deleted the feature/remove-unnecessary-cudf-imports branch December 22, 2022 02:38
ajschmidt8 pushed a commit that referenced this pull request Feb 13, 2023
For housekeeping, this PR removes unused cuDF imports across a variety of files.

It does not refactor any code that currently relies on cuDF.

Authors:
  - Nick Becker (https://github.com/beckernick)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4873
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
For housekeeping, this PR removes unused cuDF imports across a variety of files.

It does not refactor any code that currently relies on cuDF.

Authors:
  - Nick Becker (https://github.com/beckernick)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants