Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Treelite to 3.0.0 #4885

Merged
merged 7 commits into from Sep 22, 2022
Merged

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Sep 12, 2022

Upgrade Treelite to take advantage of the new serializer for tree models. Now it is possible to exchange serialized tree models between two different versions of Treelite, with certain restrictions.

Requires rapidsai/integration#532

@hcho3 hcho3 requested review from a team as code owners September 12, 2022 06:22
@github-actions github-actions bot added CMake conda conda issue CUDA/C++ gpuCI gpuCI issue labels Sep 12, 2022
@hcho3 hcho3 added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Sep 12, 2022
@hcho3 hcho3 requested a review from a team as a code owner September 12, 2022 06:51
@hcho3
Copy link
Contributor Author

hcho3 commented Sep 12, 2022

rerun tests

@hcho3 hcho3 requested a review from a team as a code owner September 13, 2022 05:08
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Sep 13, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 78.02% // Head: 79.64% // Increases project coverage by +1.62% 🎉

Coverage data is based on head (246df4c) compared to base (7a0ab85).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.10    #4885      +/-   ##
================================================
+ Coverage         78.02%   79.64%   +1.62%     
================================================
  Files               180      180              
  Lines             11385    11486     +101     
================================================
+ Hits               8883     9148     +265     
+ Misses             2502     2338     -164     
Flag Coverage Δ
dask 46.15% <ø> (-0.07%) ⬇️
non-dask 68.98% <ø> (+1.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/common/array.py 95.10% <0.00%> (-2.88%) ⬇️
python/cuml/cluster/__init__.py 100.00% <0.00%> (ø)
python/cuml/metrics/__init__.py 100.00% <0.00%> (ø)
python/cuml/preprocessing/__init__.py 100.00% <0.00%> (ø)
python/cuml/benchmark/automated/utils/utils.py 0.00% <0.00%> (ø)
python/cuml/dask/preprocessing/LabelEncoder.py 93.33% <0.00%> (ø)
...cuml/_thirdparty/sklearn/preprocessing/__init__.py 100.00% <0.00%> (ø)
python/cuml/thirdparty_adapters/adapters.py 91.54% <0.00%> (+0.05%) ⬆️
...cuml/_thirdparty/sklearn/utils/skl_dependencies.py 57.64% <0.00%> (+0.50%) ⬆️
python/cuml/preprocessing/TargetEncoder.py 85.07% <0.00%> (+1.00%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ci/gpu/build.sh Outdated
Comment on lines 79 to 82
gpuci_conda_retry remove -c conda-forge -c rapidsai -c rapidsai-nightly -c nvidia \
--force rapids-build-env rapids-notebook-env
gpuci_mamba_retry install -c conda-forge -c rapidsai -c rapidsai-nightly -c nvidia \
treelite=3.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great, just leaving a comment to delete this when the integration PR is merged

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged rapidsai/integration#532, so we can remove this and merge this PR now.

@github-actions github-actions bot removed the gpuCI gpuCI issue label Sep 19, 2022
@github-actions github-actions bot removed the Cython / Python Cython or Python issue label Sep 19, 2022
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@caryr35 caryr35 added this to PR-WIP in v22.10 Release via automation Sep 20, 2022
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v22.10 Release Sep 20, 2022
@hcho3
Copy link
Contributor Author

hcho3 commented Sep 21, 2022

Rerun tests

@dantegd
Copy link
Member

dantegd commented Sep 22, 2022

rerun tests

v22.10 Release automation moved this from PR-Needs review to PR-Reviewer approved Sep 22, 2022
@dantegd
Copy link
Member

dantegd commented Sep 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d826002 into rapidsai:branch-22.10 Sep 22, 2022
v22.10 Release automation moved this from PR-Reviewer approved to Done Sep 22, 2022
@hcho3 hcho3 deleted the upgrade_treelite branch September 22, 2022 19:43
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
Upgrade Treelite to take advantage of the new serializer for tree models. Now it is possible to exchange serialized tree models between two different versions of Treelite, with [certain restrictions](https://treelite.readthedocs.io/en/latest/notes-on-serialization.html).

Requires rapidsai/integration#532

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake conda conda issue CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants