Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Unpin dask and distributed for development #4912

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

galipremsagar
Copy link
Contributor

This PR relaxes the pinnings of dask and distributed for 22.12 development.

xref: rapidsai/cudf#11859

@galipremsagar galipremsagar requested a review from a team as a code owner October 4, 2022 17:14
@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 4, 2022
@github-actions github-actions bot added conda conda issue gpuCI gpuCI issue labels Oct 4, 2022
Copy link
Contributor

@jolorunyomi jolorunyomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

@galipremsagar
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@298f08c). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.12    #4912   +/-   ##
===============================================
  Coverage                ?   79.26%           
===============================================
  Files                   ?      181           
  Lines                   ?    11540           
  Branches                ?        0           
===============================================
  Hits                    ?     9147           
  Misses                  ?     2393           
  Partials                ?        0           
Flag Coverage Δ
dask 46.02% <0.00%> (?)
non-dask 68.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dantegd
Copy link
Member

dantegd commented Oct 14, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 522bed2 into rapidsai:branch-22.12 Oct 14, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
This PR relaxes the pinnings of `dask` and `distributed` for `22.12` development.

xref: rapidsai/cudf#11859

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Joseph (https://github.com/jolorunyomi)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants