Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to fix cuml build #4928

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Updates to fix cuml build #4928

merged 2 commits into from
Oct 14, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Oct 13, 2022

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 13, 2022
@cjnolet cjnolet requested review from a team as code owners October 13, 2022 22:57
@cjnolet cjnolet added this to PR-WIP in v22.12 Release via automation Oct 13, 2022
@github-actions github-actions bot added conda conda issue CUDA/C++ gpuCI gpuCI issue labels Oct 13, 2022
v22.12 Release automation moved this from PR-WIP to PR-Reviewer approved Oct 13, 2022
@github-actions github-actions bot added the CMake label Oct 14, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@50716cf). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-22.12    #4928   +/-   ##
===============================================
  Coverage                ?   79.35%           
===============================================
  Files                   ?      181           
  Lines                   ?    11540           
  Branches                ?        0           
===============================================
  Hits                    ?     9158           
  Misses                  ?     2382           
  Partials                ?        0
Flag Coverage Δ
dask 46.02% <0.00%> (?)
non-dask 68.75% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdice bdice mentioned this pull request Oct 14, 2022
Merged
@cjnolet
Copy link
Member Author

cjnolet commented Oct 14, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 298f08c into rapidsai:branch-22.12 Oct 14, 2022
v22.12 Release automation moved this from PR-Reviewer approved to Done Oct 14, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@cjnolet
Updates to fix cuml build (rapidsai#4928)
9a2e14c 
Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#4928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees
No one assigned
Labels
CMake conda conda issue CUDA/C++ gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v22.12 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cjnolet @codecov-commenter @dantegd @raydouglass