Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for nsys utility version in the nvtx_benchmarks.py script #4959

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Add check for nsys utility version in the nvtx_benchmarks.py script #4959

merged 2 commits into from
Nov 22, 2022

Conversation

viclafargue
Copy link
Contributor

Closes #4955

@viclafargue viclafargue requested a review from a team as a code owner October 28, 2022 08:32
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Oct 28, 2022
@viclafargue viclafargue added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 28, 2022
dantegd
dantegd requested changes Oct 28, 2022
View reviewed changes
python/cuml/benchmark/nvtx_benchmark.py Outdated Show resolved Hide resolved
@caryr35 caryr35 added this to PR-WIP in v22.12 Release via automation Nov 7, 2022
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v22.12 Release Nov 7, 2022
@viclafargue
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

Codecov Report

Base: 79.48% // Head: 80.54% // Increases project coverage by +1.05% 🎉

Coverage data is based on head (686cd63) compared to base (3c147bf).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-22.12    #4959      +/-   ##
================================================
+ Coverage         79.48%   80.54%   +1.05%     
================================================
  Files               183      184       +1     
  Lines             11618    12513     +895     
================================================
+ Hits               9235    10079     +844     
- Misses             2383     2434      +51
Flag Coverage Δ
dask 46.27% <0.00%> (+0.17%) ⬆️
non-dask 70.47% <0.00%> (+1.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/benchmark/nvtx_benchmark.py 0.00% <0.00%> (ø)
python/cuml/common/array_sparse.py 95.34% <0.00%> (-1.21%) ⬇️
python/cuml/common/memory_utils.py 81.50% <0.00%> (-0.86%) ⬇️
python/cuml/dask/cluster/kmeans.py 94.79% <0.00%> (-0.60%) ⬇️
...ython/cuml/dask/ensemble/randomforestclassifier.py 60.71% <0.00%> (-0.47%) ⬇️
python/cuml/benchmark/datagen.py 18.22% <0.00%> (-0.47%) ⬇️
python/cuml/dask/preprocessing/LabelEncoder.py 93.02% <0.00%> (-0.32%) ⬇️
python/cuml/testing/strategies.py 100.00% <0.00%> (ø)
...party/sklearn/preprocessing/_column_transformer.py 75.18% <0.00%> (+0.42%) ⬆️
python/cuml/testing/utils.py 89.65% <0.00%> (+0.45%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

v22.12 Release automation moved this from PR-Needs review to PR-Reviewer approved Nov 22, 2022
@dantegd
Copy link
Member

dantegd commented Nov 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 81621d2 into rapidsai:branch-22.12 Nov 22, 2022
v22.12 Release automation moved this from PR-Reviewer approved to Done Nov 22, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@viclafargue
Add check for nsys utility version in the nvtx_benchmarks.py script (…
63eb771 
…rapidsai#4959)

Closes rapidsai#4955

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v22.12 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Provide check to ensure compatibility of nsys version in nvtx_benchmarks.py
4 participants
@viclafargue @codecov-commenter @dantegd @wphicks