Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integer overflow in AutoARIMA due to bool-to-int cub scan #4971

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

Nyrio
Copy link
Contributor

@Nyrio Nyrio commented Nov 3, 2022

Solves #4968

@Nyrio Nyrio requested a review from a team as a code owner November 3, 2022 14:39
@Nyrio Nyrio added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change CUDA/C++ and removed CUDA/C++ labels Nov 3, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 79.51% // Head: 79.52% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ae2d07a) compared to base (02d4c64).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-22.12    #4971   +/-   ##
=============================================
  Coverage         79.51%   79.52%           
=============================================
  Files               183      183           
  Lines             11612    11617    +5     
=============================================
+ Hits               9233     9238    +5     
  Misses             2379     2379           
Flag Coverage Δ
dask 46.13% <ø> (+0.02%) ⬆️
non-dask 68.98% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/common/array.py 97.26% <0.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dantegd
Copy link
Member

dantegd commented Nov 3, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 78092dd into branch-22.12 Nov 3, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CUDA/C++ non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants