Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Pin dask and distributed for release #4999

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Nov 16, 2022

This PR pins dask and distributed to 2022.11.1 for 22.12 release.

xref: rapidsai/cudf#12165

@galipremsagar galipremsagar requested a review from a team as a code owner November 16, 2022 15:23
@github-actions github-actions bot added conda conda issue gpuCI gpuCI issue labels Nov 16, 2022
@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 16, 2022
@galipremsagar galipremsagar added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 16, 2022
@cjnolet
Copy link
Member

cjnolet commented Nov 17, 2022

@galipremsagar is this one ready to be merged?

@galipremsagar
Copy link
Contributor Author

@galipremsagar is this one ready to be merged?

No Corey, nvidia dask team has decided to hold off merging dask pinnings until Code Freeze/Testing (others) date, which is Dec 1st. There is also another anticipated release of dask between now and then, hence holding off and tagged DO NOT MERGE for now.

@cjnolet
Copy link
Member

cjnolet commented Nov 17, 2022

Ah, got it. I just realized the one we just merged into raft was to revert the pin for the dask version. I missed that when I read the title of the PR.

@cjnolet cjnolet added this to PR-WIP in v22.12 Release via automation Nov 29, 2022
@cjnolet
Copy link
Member

cjnolet commented Nov 30, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

Base: 79.44% // Head: 80.36% // Increases project coverage by +0.92% 🎉

Coverage data is based on head (c4e8407) compared to base (6500897).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12    #4999      +/-   ##
================================================
+ Coverage         79.44%   80.36%   +0.92%     
================================================
  Files               184      184              
  Lines             11698    12647     +949     
================================================
+ Hits               9293    10164     +871     
- Misses             2405     2483      +78     
Flag Coverage Δ
dask 46.34% <ø> (+0.41%) ⬆️
non-dask 70.42% <ø> (+1.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/comm/serialize.py 92.72% <0.00%> (-2.28%) ⬇️
python/cuml/common/array_sparse.py 95.34% <0.00%> (-1.21%) ⬇️
python/cuml/common/input_utils.py 93.13% <0.00%> (-0.73%) ⬇️
python/cuml/dask/cluster/kmeans.py 94.79% <0.00%> (-0.60%) ⬇️
...ython/cuml/dask/ensemble/randomforestclassifier.py 60.71% <0.00%> (-0.47%) ⬇️
python/cuml/benchmark/datagen.py 18.22% <0.00%> (-0.47%) ⬇️
python/cuml/dask/preprocessing/LabelEncoder.py 93.02% <0.00%> (-0.32%) ⬇️
python/cuml/benchmark/nvtx_benchmark.py 0.00% <0.00%> (ø)
python/cuml/experimental/common/__init__.py 100.00% <0.00%> (ø)
...party/sklearn/preprocessing/_column_transformer.py 75.18% <0.00%> (+0.42%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galipremsagar galipremsagar removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Dec 1, 2022
@cjnolet
Copy link
Member

cjnolet commented Dec 1, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 44f6f69 into rapidsai:branch-22.12 Dec 1, 2022
v22.12 Release automation moved this from PR-WIP to Done Dec 1, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
This PR pins `dask` and `distributed` to `2022.11.1` for `22.12` release.

xref: rapidsai/cudf#12165

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#4999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants