Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing raft pin to 22.12 #5000

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Nov 16, 2022

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 16, 2022
@cjnolet cjnolet requested a review from a team as a code owner November 16, 2022 15:29
@cjnolet cjnolet added this to PR-WIP in v22.12 Release via automation Nov 16, 2022
v22.12 Release automation moved this from PR-WIP to PR-Reviewer approved Nov 16, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Nov 16, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Nov 16, 2022

I think this failed because the raft packages had not been deployed yet for the fixed version when CI started building.

@codecov-commenter
Copy link

Codecov Report

Base: 79.44% // Head: 79.29% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (1b6c3b8) compared to base (6500897).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12    #5000      +/-   ##
================================================
- Coverage         79.44%   79.29%   -0.15%     
================================================
  Files               184      184              
  Lines             11698    11698              
================================================
- Hits               9293     9276      -17     
- Misses             2405     2422      +17     
Flag Coverage Δ
dask 45.93% <ø> (ø)
non-dask 68.83% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/neighbors/kernel_density.py 69.07% <0.00%> (-6.58%) ⬇️
python/cuml/metrics/pairwise_kernels.py 74.19% <0.00%> (-5.65%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cjnolet
Copy link
Member Author

cjnolet commented Nov 17, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c5ac66f into rapidsai:branch-22.12 Nov 17, 2022
v22.12 Release automation moved this from PR-Reviewer approved to Done Nov 17, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants