Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use CMake 3.25.0 as it has a FindCUDAToolkit show stopping bug #5007

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Don't use CMake 3.25.0 as it has a FindCUDAToolkit show stopping bug #5007

merged 1 commit into from
Nov 18, 2022

Conversation

robertmaynard
Copy link
Contributor

No description provided.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Nov 17, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner November 17, 2022 19:44
@robertmaynard robertmaynard added this to PR-WIP in v22.12 Release via automation Nov 17, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner November 17, 2022 19:44
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue labels Nov 17, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 79.38% // Head: 79.60% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (d16107e) compared to base (dd197b9).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-22.12    #5007      +/-   ##
================================================
+ Coverage         79.38%   79.60%   +0.22%     
================================================
  Files               184      184              
  Lines             11698    11698              
================================================
+ Hits               9286     9312      +26     
+ Misses             2412     2386      -26
Flag Coverage Δ
dask 45.93% <ø> (ø)
non-dask 69.14% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/metrics/pairwise_kernels.py 80.64% <0.00%> (+6.45%) ⬆️
python/cuml/neighbors/kernel_density.py 87.50% <0.00%> (+11.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cjnolet
Copy link
Member

cjnolet commented Nov 18, 2022

@gpucibot merge

v22.12 Release automation moved this from PR-WIP to PR-Reviewer approved Nov 18, 2022
@rapids-bot rapids-bot bot merged commit 308dd08 into rapidsai:branch-22.12 Nov 18, 2022
v22.12 Release automation moved this from PR-Reviewer approved to Done Nov 18, 2022
@robertmaynard robertmaynard deleted the bug/avoid_cmake_3.25.0 branch November 21, 2022 14:26
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@robertmaynard
Don't use CMake 3.25.0 as it has a FindCUDAToolkit show stopping bug (r…
dfde6a4 
…apidsai#5007)

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#5007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working conda conda issue Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
No open projects
v22.12 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@robertmaynard @codecov-commenter @cjnolet @ajschmidt8