Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cupy.cusparse custom serialization #5024

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Nov 23, 2022

It should be safe to remove this now that cupy/cupy#3061 has been fixed

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Nov 23, 2022
@dantegd dantegd requested a review from a team as a code owner November 23, 2022 20:34
@dantegd dantegd added this to PR-WIP in v22.12 Release via automation Nov 23, 2022
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Nov 23, 2022
v22.12 Release automation moved this from PR-WIP to PR-Reviewer approved Nov 23, 2022
@cjnolet
Copy link
Member

cjnolet commented Nov 30, 2022

rerun tests

@cjnolet
Copy link
Member

cjnolet commented Nov 30, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

Base: 79.38% // Head: 79.58% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (e8198a7) compared to base (81621d2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12    #5024      +/-   ##
================================================
+ Coverage         79.38%   79.58%   +0.19%     
================================================
  Files               184      184              
  Lines             11707    11707              
================================================
+ Hits               9294     9317      +23     
+ Misses             2413     2390      -23     
Flag Coverage Δ
dask 46.00% <ø> (+0.11%) ⬆️
non-dask 69.12% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/comm/serialize.py 94.28% <ø> (-0.72%) ⬇️
python/cuml/metrics/pairwise_kernels.py 79.83% <0.00%> (-0.81%) ⬇️
python/cuml/common/input_utils.py 93.85% <0.00%> (ø)
python/cuml/model_selection/_split.py 75.88% <0.00%> (ø)
python/cuml/experimental/common/__init__.py 100.00% <0.00%> (ø)
python/cuml/common/array.py 97.36% <0.00%> (+0.10%) ⬆️
python/cuml/common/memory_utils.py 85.32% <0.00%> (+2.97%) ⬆️
python/cuml/neighbors/kernel_density.py 87.50% <0.00%> (+11.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cjnolet
Copy link
Member

cjnolet commented Nov 30, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b962396 into rapidsai:branch-22.12 Nov 30, 2022
v22.12 Release automation moved this from PR-Reviewer approved to Done Nov 30, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
It should be safe to remove this now that cupy/cupy#3061 has been fixed

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - William Hicks (https://github.com/wphicks)

URL: rapidsai#5024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants