Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workers argument to dask make_blobs #5057

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Add workers argument to dask make_blobs #5057

merged 2 commits into from
Dec 7, 2022

Conversation

viclafargue
Copy link
Contributor

Fixes #5048

@viclafargue viclafargue requested a review from a team as a code owner December 5, 2022 16:31
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Dec 5, 2022
@viclafargue viclafargue added bug Something isn't working non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels Dec 5, 2022
@wphicks
Copy link
Contributor

wphicks commented Dec 5, 2022

@gpucibot merge

cjnolet
cjnolet requested changes Dec 6, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor things but in general I like that this change gives the user more control over how the data is generated across the cluster.

python/cuml/dask/datasets/blobs.py Show resolved Hide resolved
python/cuml/dask/datasets/blobs.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Dec 7, 2022
@viclafargue
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@1e0f40d). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-23.02    #5057   +/-   ##
===============================================
  Coverage                ?   79.50%           
===============================================
  Files                   ?      184           
  Lines                   ?    11708           
  Branches                ?        0           
===============================================
  Hits                    ?     9309           
  Misses                  ?     2399           
  Partials                ?        0
Flag Coverage Δ
dask 46.01% <0.00%> (?)
non-dask 69.04% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

cjnolet
cjnolet approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @viclafargue!

@rapids-bot rapids-bot bot merged commit cd5fbc1 into rapidsai:branch-23.02 Dec 7, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@viclafargue
Add workers argument to dask make_blobs (rapidsai#5057)
d9bf47f 
Fixes rapidsai#5048

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#5057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dask cuml - TypeError: make_blobs() got an unexpected keyword argument 'workers'[BUG]
4 participants
@viclafargue @wphicks @codecov-commenter @cjnolet