Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip RAFT docstring test in cuML #5088

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Skip RAFT docstring test in cuML #5088

merged 1 commit into from
Dec 14, 2022

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Dec 14, 2022

Handle docstring test is located in RAFT, so it is tested in that repo.

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Dec 14, 2022
@dantegd dantegd requested a review from a team as a code owner December 14, 2022 17:37
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Dec 14, 2022
csadorf
csadorf approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a TODO item to eventually remove this again?

@wphicks
Copy link
Contributor

wphicks commented Dec 14, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@013246c). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-23.02    #5088   +/-   ##
===============================================
  Coverage                ?   79.75%           
===============================================
  Files                   ?      184           
  Lines                   ?    11852           
  Branches                ?        0           
===============================================
  Hits                    ?     9453           
  Misses                  ?     2399           
  Partials                ?        0
Flag Coverage Δ
dask 45.80% <0.00%> (?)
non-dask 69.38% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rapids-bot rapids-bot bot merged commit cbfc1ba into rapidsai:branch-23.02 Dec 14, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@dantegd
Skip RAFT docstring test in cuML (rapidsai#5088)
1c87ff3 
Handle docstring test is located in RAFT, so it is tested in that repo.

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Carl Simon Adorf (https://github.com/csadorf)
  - William Hicks (https://github.com/wphicks)

URL: rapidsai#5088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csadorf csadorf csadorf approved these changes

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dantegd @wphicks @codecov-commenter @csadorf