Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PROJECT_FLASH from libcuml conda build environment. #5108

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 29, 2022

This is a small cleanup to remove the outdated PROJECT_FLASH environment variable from the libcuml recipe.

@bdice bdice requested a review from a team as a code owner December 29, 2022 01:12
@github-actions github-actions bot added the conda conda issue label Dec 29, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@5c6844c). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.02    #5108   +/-   ##
===============================================
  Coverage                ?   69.27%           
===============================================
  Files                   ?      192           
  Lines                   ?    12369           
  Branches                ?        0           
===============================================
  Hits                    ?     8569           
  Misses                  ?     3800           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 29, 2022
@dantegd
Copy link
Member

dantegd commented Jan 3, 2023

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 95a05f1 into rapidsai:branch-23.02 Jan 3, 2023
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
…5108)

This is a small cleanup to remove the outdated `PROJECT_FLASH` environment variable from the libcuml recipe.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#5108
@bdice bdice deleted the no-flash branch May 9, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants