Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nvcc conda package and add compiler/ninja to dev envs #5113

Merged
merged 4 commits into from
Jan 3, 2023

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jan 3, 2023

No description provided.

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Jan 3, 2023
@github-actions github-actions bot added the conda conda issue label Jan 3, 2023
@dantegd dantegd changed the title Remove nvcc conda package from dev envs Remove nvcc conda package and add compiler/ninja to dev envs Jan 3, 2023
@dantegd dantegd marked this pull request as ready for review January 3, 2023 21:53
@dantegd dantegd requested a review from a team as a code owner January 3, 2023 21:53
@codecov-commenter
Copy link

Codecov Report

Base: 69.36% // Head: 69.35% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (424b217) compared to base (7275e3a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02    #5113      +/-   ##
================================================
- Coverage         69.36%   69.35%   -0.01%     
================================================
  Files               192      192              
  Lines             12369    12369              
================================================
- Hits               8580     8579       -1     
- Misses             3789     3790       +1     
Impacted Files Coverage Δ
python/cuml/metrics/pairwise_kernels.py 79.83% <0.00%> (-0.81%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dantegd
Copy link
Member Author

dantegd commented Jan 3, 2023

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 96c983d into rapidsai:branch-23.02 Jan 3, 2023
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conda conda issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants