Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor API context managers #5142

Draft
wants to merge 49 commits into
base: branch-23.04
Choose a base branch
from
Draft

Refactor API context managers #5142

wants to merge 49 commits into from

Commits on Feb 14, 2023

  1. Do not require explicit "needs_self" option.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    908e522 View commit details
    Browse the repository at this point in the history

  2. Micro-refactor of api_context_managers module.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    6ce6d20 View commit details
    Browse the repository at this point in the history

  3. Eliminate ProcessEnterBaseMixin class.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    dc176df View commit details
    Browse the repository at this point in the history

  4. Remove ProcessEnter and ProcessReturn classes. 

    Those were base classes that were not independently used.
    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    3321983 View commit details
    Browse the repository at this point in the history

  5. WIP: Refactor internal api contexts to simplify cm hierarchy. 

    Removes the internals.api_context_manager module and most of the
previously required context managers.
    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    f79b637 View commit details
    Browse the repository at this point in the history

  6. Use ExitStack for stacking CMs in api_context CM.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    8cc4e22 View commit details
    Browse the repository at this point in the history

  7. Use GlobalSettings() more consistently.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    fa151f7 View commit details
    Browse the repository at this point in the history

  8. Further debugging.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    30bd645 View commit details
    Browse the repository at this point in the history

  9. Do not use global state for processing return values.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    f9765a3 View commit details
    Browse the repository at this point in the history

  10. Partially revert 4b102b9 .

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    4b94a7b View commit details
    Browse the repository at this point in the history

  11. Fix unrelated style issues.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    d6ff914 View commit details
    Browse the repository at this point in the history

  12. Restore the _API_OUTPUT_DTYPE_OVERRIDE global. 

    This will likely require a little bit of thought on how this should be
avoided.
    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    98998b2 View commit details
    Browse the repository at this point in the history

  13. Move override logic into calling function.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    c9776bf View commit details
    Browse the repository at this point in the history

  14. Convert solver_model.coef_ to CumlArray in more robust way.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    9d528a2 View commit details
    Browse the repository at this point in the history

  15. Fix ElasticNet.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    10b3b35 View commit details
    Browse the repository at this point in the history

  16. Fix ARIMA.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    83c3fc1 View commit details
    Browse the repository at this point in the history

  17. Fix ColumnTransformer

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    e5e09f3 View commit details
    Browse the repository at this point in the history

  18. The internals.set_api_output_type does not change global output_type. 

    Restores previous behavior.
    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    013a199 View commit details
    Browse the repository at this point in the history

  19. Fix DBSCAN.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    c0e4543 View commit details
    Browse the repository at this point in the history

  20. Fix ExponentialSmoothing.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    d77a09e View commit details
    Browse the repository at this point in the history

  21. Fix MBSGDClassifier.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    48b6782 View commit details
    Browse the repository at this point in the history

  22. Fix MBSGDRegressor.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    ff78fd0 View commit details
    Browse the repository at this point in the history

  23. Refactor the api_context() CM function.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    6a31e7b View commit details
    Browse the repository at this point in the history

  24. Implement exit_internal_api().

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    b8984d2 View commit details
    Browse the repository at this point in the history

  25. Fix PCA.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    1237c1e View commit details
    Browse the repository at this point in the history

  26. Fix entropy module.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    80b704e View commit details
    Browse the repository at this point in the history

  27. Fix multiclass.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    a80da27 View commit details
    Browse the repository at this point in the history

  28. Fix output_type override logic.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    b5c488b View commit details
    Browse the repository at this point in the history

  29. Fix SVC.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    eb0abf3 View commit details
    Browse the repository at this point in the history

  30. Consolidate API context globals into dataclass. 

    Better design, but also simplifies temporarily replacing the context
within the exit_internal_api() context.
    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    f3e837a View commit details
    Browse the repository at this point in the history

  31. Fix kneighbors_graph.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    78c077c View commit details
    Browse the repository at this point in the history

  32. Fix BaseRandomForestModel.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    1f020b7 View commit details
    Browse the repository at this point in the history

  33. Set set_output_type=True for auto-wrapped "fit" functions.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    c72d720 View commit details
    Browse the repository at this point in the history

  34. Revert changes to test_api.py

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    1aab6a5 View commit details
    Browse the repository at this point in the history

  35. Minor refactor of f8a3106.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    11b0f18 View commit details
    Browse the repository at this point in the history

  36. Fixup ARIMA (19a7d39).

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    66adc3a View commit details
    Browse the repository at this point in the history

  37. Partially revert 440d6ab.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    5b17f6d View commit details
    Browse the repository at this point in the history

  38. Move ApiContext global into _GlobalSettingsData. 

    And slightly adjust variable names.
    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    8bd3902 View commit details
    Browse the repository at this point in the history

  39. Auto-convert to CumlArray for API-internal functions.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    798ee95 View commit details
    Browse the repository at this point in the history

  40. Fix bug in the generic conversion of sparse arrays.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    1764a46 View commit details
    Browse the repository at this point in the history

  41. Consolidate internals namespace imports.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    0e1ac45 View commit details
    Browse the repository at this point in the history

  42. Consolidate api decorator definitions.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    6fc2e18 View commit details
    Browse the repository at this point in the history

  43. Update TODO items.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    369d610 View commit details
    Browse the repository at this point in the history

  44. Respect globally specified output_type also for internal api calls.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    b3d1a0c View commit details
    Browse the repository at this point in the history

  45. Remove obsolete output_dtype property from global settings.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    e81fad3 View commit details
    Browse the repository at this point in the history

  46. Fix MBSGDClassifier.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    689717b View commit details
    Browse the repository at this point in the history

  47. Fix MBSGDRegressor.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    a307b42 View commit details
    Browse the repository at this point in the history

  48. Fix SVC.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    c907da2 View commit details
    Browse the repository at this point in the history

  49. Fix TfidfTransformer.

    @csadorf
    csadorf committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    b5fc198 View commit details
    Browse the repository at this point in the history