Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _predict_model_on_cpu for RandomForestClassifier #5148

Merged
merged 7 commits into from
Feb 5, 2023
Merged

Add _predict_model_on_cpu for RandomForestClassifier #5148

merged 7 commits into from
Feb 5, 2023

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Jan 23, 2023

Closes #5008

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 23, 2023
@lowener lowener changed the title Add _predict_model_on_cpu Add _predict_model_on_cpu for RandomForestClassifier Jan 23, 2023
@lowener lowener added bug Something isn't working non-breaking Non-breaking change labels Jan 23, 2023
@lowener lowener marked this pull request as ready for review January 24, 2023 14:43
@lowener lowener requested a review from a team as a code owner January 24, 2023 14:43
@codecov-commenter
Copy link

Codecov Report

Base: 67.12% // Head: 67.17% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (7712ee4) compared to base (85b33df).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-23.02    #5148      +/-   ##
================================================
+ Coverage         67.12%   67.17%   +0.04%     
================================================
  Files               192      192              
  Lines             12396    12425      +29     
================================================
+ Hits               8321     8346      +25     
- Misses             4075     4079       +4
Impacted Files Coverage Δ
python/cuml/common/device_selection.py 93.33% <50.00%> (-6.67%) ⬇️
...ython/cuml/dask/ensemble/randomforestclassifier.py 31.86% <66.66%> (+1.18%) ⬆️
python/cuml/common/sparsefuncs.py 92.24% <86.04%> (-0.15%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dantegd
Copy link
Member

dantegd commented Feb 5, 2023

/merge

@rapids-bot rapids-bot bot merged commit 8f15cc1 into rapidsai:branch-23.02 Feb 5, 2023
@lowener lowener deleted the 23.02-predict-rfc branch February 5, 2023 21:22
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@lowener
Add _predict_model_on_cpu for RandomForestClassifier (rapidsai#5148)
fac0e24 
Closes rapidsai#5008

Authors:
  - Micka (https://github.com/lowener)
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#5148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees

@lowener lowener

Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] RandomForestClassifier No attribute predict_model_on_cpu when it should ?
3 participants
@lowener @codecov-commenter @dantegd