Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable hypothesis tests for 23.02 burndown. #5168

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Disable hypothesis tests for 23.02 burndown. #5168

merged 2 commits into from
Jan 31, 2023

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Jan 26, 2023

No description provided.

@csadorf csadorf requested a review from a team as a code owner January 26, 2023 18:06
@csadorf csadorf self-assigned this Jan 26, 2023
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 26, 2023
@csadorf csadorf added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 26, 2023
@csadorf
Copy link
Contributor Author

csadorf commented Jan 27, 2023

@cjnolet Can you rerun the failed test? Looks like a fluke.

@codecov-commenter
Copy link

Codecov Report

Base: 69.26% // Head: 67.21% // Decreases project coverage by -2.06% ⚠️

Coverage data is based on head (42d818e) compared to base (de32125).
Patch coverage: 24.44% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-23.02    #5168      +/-   ##
================================================
- Coverage         69.26%   67.21%   -2.06%     
================================================
  Files               192      192              
  Lines             12333    12370      +37     
================================================
- Hits               8543     8314     -229     
- Misses             3790     4056     +266
Impacted Files Coverage Δ
python/cuml/testing/strategies.py 33.76% <19.04%> (-60.31%) ⬇️
...ing/text/stem/porter_stemmer_utils/suffix_utils.py 91.11% <100.00%> (+0.20%) ⬆️
python/cuml/neighbors/kernel_density.py 52.59% <0.00%> (-35.07%) ⬇️
python/cuml/metrics/pairwise_kernels.py 70.07% <0.00%> (-11.03%) ⬇️
python/cuml/testing/utils.py 78.63% <0.00%> (-10.39%) ⬇️
python/cuml/internals/memory_utils.py 78.18% <0.00%> (-8.19%) ⬇️
python/cuml/internals/array.py 81.62% <0.00%> (-6.53%) ⬇️
python/cuml/feature_extraction/_vectorizers.py 84.38% <0.00%> (-5.65%) ⬇️
python/cuml/common/kernel_utils.py 91.66% <0.00%> (-4.17%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@csadorf
Copy link
Contributor Author

csadorf commented Jan 31, 2023

@cjnolet @dantegd This looks like it is ready to merge.

@cjnolet
Copy link
Member

cjnolet commented Jan 31, 2023

/merge

@rapids-bot rapids-bot bot merged commit 348a8cb into rapidsai:branch-23.02 Jan 31, 2023
@csadorf csadorf deleted the disable-hypothesis-for-23.02-burndown branch January 31, 2023 12:11
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@csadorf
Disable hypothesis tests for 23.02 burndown. (rapidsai#5168)
59d20cc 
Authors:
  - Carl Simon Adorf (https://github.com/csadorf)
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#5168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@csadorf csadorf

Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@csadorf @codecov-commenter @cjnolet @dantegd