Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support numeric, boolean, and string keyword arguments to class methods during CPU dispatching #5236

Merged
merged 7 commits into from
Apr 3, 2023
Merged

Support numeric, boolean, and string keyword arguments to class methods during CPU dispatching #5236

merged 7 commits into from
Apr 3, 2023

Conversation

beckernick
Copy link
Member

This PR:

  • Updates the CPU dispatching logic to support keyword arguments that are numeric, boolean, and strings (i.e., things that can't be coerced to cuml arrays). It doesn't support passing sequences, as I believe this use case isn't necessary
  • Makes a minor update to the tests to test this dispatching in principle. We may want to expand the testing of keyword arguments in general, but as this is likely worth a broader discussion/test expansion I thought it might be out of scope for this small PR

Closes #5218

This is a replacement for #5223

@beckernick
Updates the CPU dispatching logic to support keyword arguments that a…
1245494 
…re numeric, boolean, and strings (i.e., things that can't be coerced to cuml arrays). Continuation of rapidsai#5223
@beckernick
cleanup
42ce632
@beckernick
fix typo
6640939
@beckernick beckernick added bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change labels Feb 15, 2023
@beckernick beckernick self-assigned this Feb 15, 2023
@beckernick beckernick mentioned this pull request Feb 15, 2023
Closed
@beckernick beckernick marked this pull request as ready for review February 15, 2023 18:04
@beckernick beckernick requested a review from a team as a code owner February 15, 2023 18:04
@dantegd
Copy link
Member

dantegd commented Apr 3, 2023

/merge

@rapids-bot rapids-bot bot merged commit 4c6b880 into rapidsai:branch-23.04 Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees

@beckernick beckernick

Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] CPU dispatch fails with arguments that can't be coerced to an array-like object by existing utilities
2 participants
@beckernick @dantegd