Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Python builtins to prep benchmark tmp_dir #5537

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Use Python builtins to prep benchmark tmp_dir #5537

merged 2 commits into from
Aug 1, 2023

Conversation

jakirkham
Copy link
Member

There are equivalent Python builtin functions for each of these operations. So run them instead of using a subprocess, which is a bit heavy weight

@jakirkham jakirkham requested a review from a team as a code owner July 31, 2023 21:18
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jul 31, 2023
@jakirkham jakirkham mentioned this pull request Jul 31, 2023
Merged
@csadorf
Copy link
Contributor

csadorf commented Jul 31, 2023

Blocked by #5536 .

csadorf
csadorf approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jakirkham
Copy link
Member Author

Thanks Simon! 🙏

@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 31, 2023
@bdice
Copy link
Contributor

bdice commented Aug 1, 2023

This is now unblocked -- merging upstream to rerun CI.

@jakirkham jakirkham changed the title Use Python functions to prep temp directory Use Python builtins to prep benchmark tmp_dir Aug 1, 2023
@csadorf
Copy link
Contributor

csadorf commented Aug 1, 2023

/merge

@rapids-bot rapids-bot bot merged commit 06ded20 into rapidsai:branch-23.10 Aug 1, 2023
52 checks passed
@jakirkham jakirkham deleted the use_py_ops_bench branch August 1, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csadorf csadorf csadorf approved these changes

Assignees
No one assigned
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakirkham @csadorf @bdice