Fixes for timeouts in tests #5598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csadorf
reviewed
Oct 2, 2023
csadorf
approved these changes
Oct 4, 2023
| @@ -296,7 +296,7 @@ class CD(Base, | |||
| <double>self.tol, | |||
| <double*>sample_weight_ptr) | |||
|
|
|||
| self.intercept_ = _c_intercept2_f64 | |||
| self.intercept_ = _c_intercept2_f64 | |||
There was a problem hiding this comment.
yeah, it just seemed way to small of a change to warrant a full PR with CI run
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeouts in CI were happening due to CUDA context creation happening in some dask estimator docstrings, this PR fixes that by avoiding that context creation.
Also fixes a typo in the coordinate descent solver that caused the intercept to be calculated wrong in some cases