Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Treelite 4.0 #5701

Merged
merged 32 commits into from
Jan 31, 2024
Merged

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Dec 15, 2023

Test cuML with Treelite 4.0 RC1.

This PR should be merged only when Treelite 4.0 release is finalized.

Supersedes #5650

@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue CMake CUDA/C++ labels Dec 15, 2023
@hcho3 hcho3 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 15, 2023
@github-actions github-actions bot added the ci label Dec 15, 2023
@hcho3
Copy link
Contributor Author

hcho3 commented Dec 19, 2023

rerun tests

@hcho3 hcho3 closed this Dec 19, 2023
@hcho3 hcho3 reopened this Dec 19, 2023
@hcho3 hcho3 closed this Dec 30, 2023
@hcho3 hcho3 reopened this Dec 30, 2023
@hcho3 hcho3 closed this Jan 4, 2024
@hcho3 hcho3 reopened this Jan 4, 2024
@hcho3 hcho3 closed this Jan 13, 2024
@hcho3 hcho3 reopened this Jan 13, 2024
@hcho3 hcho3 closed this Jan 14, 2024
@hcho3 hcho3 reopened this Jan 14, 2024
@hcho3 hcho3 closed this Jan 14, 2024
@hcho3 hcho3 reopened this Jan 14, 2024
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the changes I'm seeing here! They really show how many improvements Treelite 4.0 brings to the table. I posted one question before approval, but overall things look great.

Given how significant this change is, we might want to do a test of building the Triton backend for FIL either against this branch or immediately after it is merged, but I'm guessing there will be no or minimal issues.

cpp/src/decisiontree/decisiontree.cuh Show resolved Hide resolved
cpp/src/fil/treelite_import.cu Show resolved Hide resolved
@hcho3 hcho3 closed this Jan 19, 2024
@hcho3 hcho3 reopened this Jan 19, 2024
@hcho3 hcho3 closed this Jan 29, 2024
@hcho3 hcho3 reopened this Jan 29, 2024
@hcho3 hcho3 closed this Jan 29, 2024
@hcho3 hcho3 reopened this Jan 29, 2024
Copy link

copy-pr-bot bot commented Jan 29, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@hcho3 hcho3 closed this Jan 30, 2024
@hcho3 hcho3 reopened this Jan 30, 2024
@dantegd
Copy link
Member

dantegd commented Jan 31, 2024

/merge

@rapids-bot rapids-bot bot merged commit 1ee99d7 into rapidsai:branch-24.02 Jan 31, 2024
104 of 105 checks passed
@hcho3 hcho3 deleted the update_treelite_new branch January 31, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants