Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment-agnostic scripts for running ctests and pytests #5761

Merged
merged 10 commits into from
Feb 27, 2024

Conversation

trxcllnt
Copy link
Collaborator

@trxcllnt trxcllnt commented Feb 7, 2024

This PR adds environment-agnostic run_*_{ctests,pytests}.sh scripts, and updates test_*_{cpp,python}.sh to call them.

The test_*_{cpp,python}.sh scripts assume they're running in our CI environment, and they do more than just run the tests.

This PR allows devs and downstream consumers to only run the tests, and skip the unrelated logic in test_*_{cpp,python}.sh.

@trxcllnt trxcllnt requested a review from a team as a code owner February 7, 2024 08:14
@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 7, 2024
@github-actions github-actions bot added ci and removed 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 7, 2024
@trxcllnt trxcllnt requested a review from dantegd February 7, 2024 08:14
@trxcllnt trxcllnt added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 7, 2024
@dantegd
Copy link
Member

dantegd commented Feb 27, 2024

/merge

@rapids-bot rapids-bot bot merged commit ec75703 into rapidsai:branch-24.04 Feb 27, 2024
52 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants