Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pytest_cases.fixture to fix warnings. #5798

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Use pytest_cases.fixture to fix warnings. #5798

merged 2 commits into from
Mar 27, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 13, 2024

This PR fixes some warnings in tests by using pytest_cases.fixture instead of pytest_cases.fixture_plus.

test_device_selection.py:198
  /__w/cuml/cuml/python/cuml/tests/test_device_selection.py:198: DeprecationWarning: `pytest_fixture_plus` and `fixture_plus` are deprecated. Please use the new alias `fixture`. See https://github.com/pytest-dev/pytest/issues/6475
    @fixture_plus(

test_device_selection.py:235
  /__w/cuml/cuml/python/cuml/tests/test_device_selection.py:235: DeprecationWarning: `pytest_fixture_plus` and `fixture_plus` are deprecated. Please use the new alias `fixture`. See https://github.com/pytest-dev/pytest/issues/6475
    @fixture_plus(

test_device_selection.py:277
  /__w/cuml/cuml/python/cuml/tests/test_device_selection.py:277: DeprecationWarning: `pytest_fixture_plus` and `fixture_plus` are deprecated. Please use the new alias `fixture`. See https://github.com/pytest-dev/pytest/issues/6475
    @fixture_plus(

test_device_selection.py:317
  /__w/cuml/cuml/python/cuml/tests/test_device_selection.py:317: DeprecationWarning: `pytest_fixture_plus` and `fixture_plus` are deprecated. Please use the new alias `fixture`. See https://github.com/pytest-dev/pytest/issues/6475
    @fixture_plus(

test_device_selection.py:357
  /__w/cuml/cuml/python/cuml/tests/test_device_selection.py:357: DeprecationWarning: `pytest_fixture_plus` and `fixture_plus` are deprecated. Please use the new alias `fixture`. See https://github.com/pytest-dev/pytest/issues/6475
    @fixture_plus(

test_device_selection.py:392
  /__w/cuml/cuml/python/cuml/tests/test_device_selection.py:392: DeprecationWarning: `pytest_fixture_plus` and `fixture_plus` are deprecated. Please use the new alias `fixture`. See https://github.com/pytest-dev/pytest/issues/6475
    @fixture_plus(

test_device_selection.py:440
  /__w/cuml/cuml/python/cuml/tests/test_device_selection.py:440: DeprecationWarning: `pytest_fixture_plus` and `fixture_plus` are deprecated. Please use the new alias `fixture`. See https://github.com/pytest-dev/pytest/issues/6475
    @fixture_plus(

test_device_selection.py:480
  /__w/cuml/cuml/python/cuml/tests/test_device_selection.py:480: DeprecationWarning: `pytest_fixture_plus` and `fixture_plus` are deprecated. Please use the new alias `fixture`. See https://github.com/pytest-dev/pytest/issues/6475
    @fixture_plus(

test_device_selection.py:519
  /__w/cuml/cuml/python/cuml/tests/test_device_selection.py:519: DeprecationWarning: `pytest_fixture_plus` and `fixture_plus` are deprecated. Please use the new alias `fixture`. See https://github.com/pytest-dev/pytest/issues/6475
    @fixture_plus(

@bdice bdice requested a review from a team as a code owner March 13, 2024 15:45
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 13, 2024
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 19, 2024
@mroeschke mroeschke mentioned this pull request Mar 27, 2024
Closed
@bdice bdice changed the base branch from branch-24.04 to branch-24.06 March 27, 2024 15:39
@bdice
Copy link
Contributor Author

bdice commented Mar 27, 2024

/merge

@rapids-bot rapids-bot bot merged commit 4a4d313 into rapidsai:branch-24.06 Mar 27, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bdice @dantegd