Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly CI: remove deprecated creation of columns by using explicit dtype #5880

Merged
merged 2 commits into from
May 3, 2024
Merged

Fix nightly CI: remove deprecated creation of columns by using explicit dtype #5880

merged 2 commits into from
May 3, 2024

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented May 2, 2024 •
edited
Loading

After turning warnings as errors in pytests, the following error is blocking nightly (and I presume PR) CI:

================================================================================================================================================= short test summary info ==================================================================================================================================================
FAILED cuml/tests/test_array.py::test_get_set_item - FutureWarning: Setting an item of incompatible dtype is deprecated and will raise in a future error of pandas. Value '1.0' has dtype incompatible with int8, please explicitly cast to a compatible dtype first.

This PR fixes that by explicitly assigning columns with the correct type scalars.

@github-actions github-actions bot added the Cython / Python Cython or Python issue label May 2, 2024
@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels May 2, 2024
@dantegd dantegd marked this pull request as ready for review May 3, 2024 01:02
@dantegd dantegd requested a review from a team as a code owner May 3, 2024 01:02
@dantegd dantegd changed the title Fix CI: remove deprecated creation of columns by using explicit dtype Fix nightly CI: remove deprecated creation of columns by using explicit dtype May 3, 2024
@dantegd
Copy link
Member Author

dantegd commented May 3, 2024

/merge

@rapids-bot rapids-bot bot merged commit 83fc3b7 into rapidsai:branch-24.06 May 3, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dantegd @divyegala