Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

[BUG] FutureWarning from CuPy on resample #471

Open
charlesbluca opened this issue Apr 1, 2022 · 2 comments
Open

[BUG] FutureWarning from CuPy on resample #471

charlesbluca opened this issue Apr 1, 2022 · 2 comments
Labels
? - Needs Triage Need team to review and classify doc Documentation inactive-30d inactive-90d

Comments

@charlesbluca
Copy link
Member

charlesbluca commented Apr 1, 2022

Describe the bug
When resampling a CuPy array, we get a FutureWarning instructing us not to use a non-tuple sequence for multidimensional indexing:

/opt/conda/envs/rapids/lib/python3.9/site-packages/cusignal-22.4.0a0+g8878bf7-py3.9.egg/cusignal/filtering/resample.py:269: FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[cupy.array(seq)]`, which will result either in an error or a different result.
  Y[sl] = X[sl]

Steps/Code to reproduce bug
With latest 22.06 conda nightlies:

import cupy as cp
import cusignal

start = 0
stop = 10
num = int(1e8)
resample_num = int(1e5)

gx = cp.linspace(start, stop, num, endpoint=False)
gy = cp.cos(-gx**2/6.0)

gf = cusignal.resample(gy, resample_num)

Expected behavior
Would not expect this warning to appear when resampling.

Environment details (please complete the following information):

  • Environment location: bare-metal
  • Method of cuSignal install: conda

Additional context
Came across this issue while testing the filtering examples notebook.

@charlesbluca charlesbluca added ? - Needs Triage Need team to review and classify doc Documentation labels Apr 1, 2022
@github-actions github-actions bot added this to Needs prioritizing in Other Issues Apr 1, 2022
@charlesbluca charlesbluca changed the title [DOC] FutureWarning on resample in filtering_examples.ipynb [BUG] FutureWarning from CuPy on resample Apr 6, 2022
@github-actions
Copy link

github-actions bot commented May 6, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
? - Needs Triage Need team to review and classify doc Documentation inactive-30d inactive-90d
Projects
Status: No status
Other Issues
Needs prioritizing
Development

No branches or pull requests

1 participant