Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Google Benchmark from rapids-cmake in cuproj. #1225

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Use Google Benchmark from rapids-cmake in cuproj. #1225

merged 2 commits into from
Jul 21, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jul 20, 2023

Description

Follow-up to #1224 for cuproj.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner July 20, 2023 16:51
@bdice bdice requested a review from robertmaynard July 20, 2023 16:51
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Jul 20, 2023
@bdice
Copy link
Contributor Author

bdice commented Jul 21, 2023

/merge

@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 21, 2023
@bdice bdice self-assigned this Jul 21, 2023
@bdice
Copy link
Contributor Author

bdice commented Jul 21, 2023

For some reason CI didn't run the first time. 😕 I kicked it with an empty commit and it seems to be fine now.

@rapids-bot rapids-bot bot merged commit 7cacad2 into rapidsai:branch-23.08 Jul 21, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees

@bdice bdice

Labels
cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bdice @robertmaynard