Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Reduce template parameters #110

Open
3 tasks
cjnolet opened this issue May 8, 2024 · 1 comment
Open
3 tasks

[FEA] Reduce template parameters #110

cjnolet opened this issue May 8, 2024 · 1 comment
Labels
feature request New feature or request

Comments

@cjnolet
Copy link
Member

cjnolet commented May 8, 2024

Currently, there's a lot of template params that could easily become runtime parameter. Every template param causes the need to compile more instantiations. If we reduce template params, we will improve compile time and binary size.

  • Pairwise distances distance metric arg
  • ANN filter type (make polymorphic)
  • Reduce CAGRA / CAGRA-Q templates (make more runtime hyper-params)

@tfeher @divyegala @achirkin @benfred please add to this list as opportunities arise.

@cjnolet cjnolet added the feature request New feature or request label May 8, 2024
@cjnolet
Copy link
Member Author

cjnolet commented May 17, 2024

  • Remove Linkage template parameter from the single linkage internals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant