Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUDA 12 Support #1201

Merged
merged 7 commits into from
Jun 28, 2023
Merged

CUDA 12 Support #1201

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
415cc03
add cuda 12 to matrix
quasiben Jun 22, 2023
1686d6f
use cuda-version for cuda 12
quasiben Jun 22, 2023
99017fa
Update GHA to cuda-120 branch
pentschev Jun 23, 2023
6dfedd7
Update installation docs
pentschev Jun 23, 2023
bfb8739
Merge remote-tracking branch 'upstream/branch-23.08' into cuda-12-sup…
pentschev Jun 27, 2023
5f76e0d
Add missing `cuda-version` constraint to `dependencies.yaml`
pentschev Jun 27, 2023
9fa0976
Add `cuda-nvcc` to satisfy Numba's CUDA dependencies
pentschev Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ dependencies:
cuda: "11.8"
packages:
- cudatoolkit=11.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change all these entries like the example below? This is needed to constrain the CUDA version of the RAPIDS packages used for Python testing. (It may be possible to derive the correct constraint from a pin on cudatoolkit but that's going to be less direct for the environment solver.)

Suggested change
- cudatoolkit=11.8
- cuda-version=11.8
- cudatoolkit

- matrix:
cuda: "12.0"
packages:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need cuda-nvrtc for Numba?

Copy link

@gmarkall gmarkall Jun 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get away without it if you're not linking .cu files with Python kernels or using float16. But for full functionality it should be present.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this suggestion below

- cuda-version=12.0
jakirkham marked this conversation as resolved.
Show resolved Hide resolved
develop:
common:
- output_types: [conda, requirements]
Expand Down