Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests that require cuDF/UCX-Py, when not installed #411

Merged
merged 4 commits into from Oct 8, 2020

Conversation

pentschev
Copy link
Member

No description provided.

@pentschev pentschev requested a review from a team as a code owner October 7, 2020 21:18
@jakirkham
Copy link
Member

@pentschev
Copy link
Member Author

Pretty bizarre, I fixed some issues, but in the current build where style checking passed, formatting is still failing https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/dask-cuda/job/prb/job/dask-cuda-style/589/display/redirect. What's even more bizarre is that my local black report is very different from that of CI, and flake8 reports nothing locally.

@jakirkham
Copy link
Member

We pin the flake8 and black versions ( rapidsai/integration#74 ). So it may be discrepancies between the latest versions and what we have pinned.

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #411 into branch-0.16 will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.16     #411   +/-   ##
============================================
  Coverage        56.86%   56.86%           
============================================
  Files               19       19           
  Lines             1442     1442           
============================================
  Hits               820      820           
  Misses             622      622           
Impacted Files Coverage Δ
dask_cuda/explicit_comms/dataframe_shuffle.py 95.52% <ø> (ø)
dask_cuda/local_cuda_cluster.py 82.95% <0.00%> (ø)
dask_cuda/utils.py 87.31% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6cfacc...c3906d1. Read the comment docs.

@pentschev
Copy link
Member Author

Aha! That makes so much more sense @jakirkham . I now fixed black formatting, but CI still complains about flake8, even though it doesn't tell us anything about the error, and locally I installed the same version as CI https://github.com/rapidsai/integration/pull/74/files#diff-16b61a6b2eb5b806543058cb7d3fca83R59 but don't see any errors.

One more interesting thing is isort complains about an error, and if you fix that, then black complains about that and fixes that, which in turn fails for isort. We really need to keep ordering consistent. :)

@jakirkham
Copy link
Member

Yeah I was running into an error like this before as well. Had opened PR ( #350 ) to address it, but I don't think we settled on exactly how we want to resolve the conflict between these tools.

@jakirkham
Copy link
Member

rerun tests

1 similar comment
@jakirkham
Copy link
Member

rerun tests

@jakirkham jakirkham merged commit 0411e3b into rapidsai:branch-0.16 Oct 8, 2020
@jakirkham
Copy link
Member

Thanks Peter! 😄

@pentschev pentschev deleted the skip-cudf-ucx-tests branch November 9, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants