New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip tests that require cuDF/UCX-Py, when not installed #411
Conversation
Looks like |
Pretty bizarre, I fixed some issues, but in the current build where style checking passed, formatting is still failing https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/dask-cuda/job/prb/job/dask-cuda-style/589/display/redirect. What's even more bizarre is that my local black report is very different from that of CI, and flake8 reports nothing locally. |
We pin the |
Codecov Report
@@ Coverage Diff @@
## branch-0.16 #411 +/- ##
============================================
Coverage 56.86% 56.86%
============================================
Files 19 19
Lines 1442 1442
============================================
Hits 820 820
Misses 622 622
Continue to review full report at Codecov.
|
Aha! That makes so much more sense @jakirkham . I now fixed black formatting, but CI still complains about flake8, even though it doesn't tell us anything about the error, and locally I installed the same version as CI https://github.com/rapidsai/integration/pull/74/files#diff-16b61a6b2eb5b806543058cb7d3fca83R59 but don't see any errors. One more interesting thing is isort complains about an error, and if you fix that, then black complains about that and fixes that, which in turn fails for isort. We really need to keep ordering consistent. :) |
Yeah I was running into an error like this before as well. Had opened PR ( #350 ) to address it, but I don't think we settled on exactly how we want to resolve the conflict between these tools. |
rerun tests |
1 similar comment
rerun tests |
Thanks Peter! 😄 |
No description provided.