Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to sccache v0.7.7 #228

Merged
merged 7 commits into from
Feb 9, 2024
Merged

Update to sccache v0.7.7 #228

merged 7 commits into from
Feb 9, 2024

Conversation

trxcllnt
Copy link
Collaborator

@trxcllnt trxcllnt commented Feb 8, 2024

Update sccache to fix mozilla/sccache#2038

bdice
bdice reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the last update: aba251d.

Do we also need to update features/src/sccache/devcontainer-feature.json to remove 0.7.4 as a candidate feature version, and replace it with 0.7.7?

@KyleFromNVIDIA
Copy link

IMO, there should be no trace of 0.7.4 or 0.7.5 being allowed to be used anywhere. We should replace it.

@trxcllnt trxcllnt merged commit bf19337 into rapidsai:branch-24.04 Feb 9, 2024
53 of 120 checks passed
@trxcllnt trxcllnt deleted the fea/sccache-0.7.7 branch February 9, 2024 00:45
@jrhemstad jrhemstad mentioned this pull request Feb 9, 2024
Merged
trxcllnt added a commit to trxcllnt/devcontainers that referenced this pull request Feb 9, 2024
@trxcllnt
Update to sccache v0.7.7 (rapidsai#228)
8982af4
trxcllnt added a commit to trxcllnt/devcontainers that referenced this pull request Feb 9, 2024
@trxcllnt
Update to sccache v0.7.7 (rapidsai#228)
63b7534
trxcllnt added a commit that referenced this pull request Feb 9, 2024
@trxcllnt
Backport sccache v0.7.7 update to branch-24.02 (#231)
1b85460 
* Update to sccache v0.7.7 (#228)

* Fix `devcontainer-utils-vault-s3-init` for `sccache@v0.7.7` (#229)
trxcllnt added a commit that referenced this pull request Feb 9, 2024
@trxcllnt
Backport sccache v0.7.7 update to branch-23.12 (#232)
c2aad81 
* Update to sccache v0.7.7 (#228)

* Fix `devcontainer-utils-vault-s3-init` for `sccache@v0.7.7` (#229)

* login to dockerhub so we don't hit rate limits (#224)

* fix oneapi feature tests

* fix bad merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

common_args is not included in preprocessor caching
3 participants
@trxcllnt @KyleFromNVIDIA @bdice